[webkit-reviews] review denied: [Bug 114987] fourthTier: Create an equivalent of Structure::get() that can work from a compilation thread : [Attachment 199113] the patch

[bugzilla-daemon at webkit.org]

Michael Saboff <msaboff at apple.com> has denied Filip Pizlo <fpizlo at apple.com>'s
request for review:
Bug 114987: fourthTier: Create an equivalent of Structure::get() that can work
from a compilation thread
https://bugs.webkit.org/show_bug.cgi?id=114987

Attachment 199113: the patch
https://bugs.webkit.org/attachment.cgi?id=199113&action=review

------- Additional Comments from Michael Saboff <msaboff at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=199113&action=review


> Source/JavaScriptCore/runtime/Structure.cpp:274
> +	   createPropertyMap(AssumeLocked, vm,
numberOfSlotsForLastOffset(m_offset, m_inlineCapacity));

You need to have a lock here through the end of the function in the create
case.