[webkit-reviews] review granted: [Bug 114650] WebKit should not decode or support PDF favicons : [Attachment 198210] patch

[bugzilla-daemon at webkit.org]

mitz at webkit.org <mitz at webkit.org> has granted Tim Horton
<timothy_horton at apple.com>'s request for review:
Bug 114650: WebKit should not decode or support PDF favicons
https://bugs.webkit.org/show_bug.cgi?id=114650

Attachment 198210: patch
https://bugs.webkit.org/attachment.cgi?id=198210&action=review

------- Additional Comments from mitz at webkit.org <mitz at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=198210&action=review


> Source/WebCore/loader/icon/IconLoader.cpp:100
> +    static const char* pdfMagicNumber = "%PDF";
> +    static unsigned pdfMagicNumberLength = strlen(pdfMagicNumber);

I would have done this with a uint32_t constant (and gotten it wrong on big
endian) or a char array that I could sizeof() instead of using strlen().