[webkit-reviews] review denied: [Bug 114842] [WK2] The nonCompositedContentLayer does not show even if WEBKIT_SHOW_COMPOSITING_DEBUG_VISUALS is set to 1. : [Attachment 198788] Patch

[bugzilla-daemon at webkit.org]

Benjamin Poulain <benjamin at webkit.org> has denied Keonil Jeong
<keonil.jeong at lge.com>'s request for review:
Bug 114842: [WK2] The nonCompositedContentLayer does not show even if
WEBKIT_SHOW_COMPOSITING_DEBUG_VISUALS is set to 1.
https://bugs.webkit.org/show_bug.cgi?id=114842

Attachment 198788: Patch
https://bugs.webkit.org/attachment.cgi?id=198788&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=198788&action=review


> Source/WebKit2/ChangeLog:12
> +	   The showDebugBorders() and showRepaintCounter() functions of
settings
> +	   return false even if WEBKIT_SHOW_COMPOSITING_DEBUG_VISUALS is set to
1
> +	   when CoordinatedLayerTreeHost is created.
> +	   This patch moves the position of functions call after settings is
made.

This is a good start. But the first paragraph does not tell why
showDebugBorders() and showRepaintCounter() return false at that point.

The second paragraph does not say why setNonCompositedContentsNeedDisplay() is
the right place for the settings.
Of all places, setNonCompositedContentsNeedDisplay() is an odd call site for
changing a layer configuration.