[webkit-reviews] review denied: [Bug 107510] [EFL][WK2] Add an API for getting context menu item's parent menu : [Attachment 198123] rebased patch

[bugzilla-daemon at webkit.org]

Benjamin Poulain <benjamin at webkit.org> has denied Michal Pakula vel Rutka
<m.pakula at samsung.com>'s request for review:
Bug 107510: [EFL][WK2] Add an API for getting context menu item's parent menu
https://bugs.webkit.org/show_bug.cgi?id=107510

Attachment 198123: rebased patch
https://bugs.webkit.org/attachment.cgi?id=198123&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=198123&action=review


Signed off by me for WebKit2 if fixed. The patch needs a review from a EFL
reviewer.


For all the comments in test_ewk2_context_menu.cpp: your comment should not
explain the next line. Instead, it should say _why_ that particular value is
expected.

> Source/WebKit2/UIProcess/API/efl/ewk_context_menu_item_private.h:66
> +    EwkContextMenu* parentMenu() { return m_parentMenu; }

const

> Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_context_menu.cpp:49
> +    // Check if parent menu equals when context menu items where created by
WebKit.

where -> were

> Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_context_menu.cpp:73
> +    // Check if parent menu equals when context menu items where created
using ewk_context_menu_item_new and added using ewk_context_menu_item_append.

? "Check if parent menu equals when" ?

> Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_context_menu.cpp:85
> +    // Check if parent menu equals when context menu items where created
using ewk_context_menu_new_with_items

Ditto.

> Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_context_menu.cpp:93
> +    // Check if parent menu equals when context menu items where created
using ewk_context_menu_item_new_with_submenu and added using
ewk_context_menu_item_append.

Ditto.