[webkit-reviews] review granted: [Bug 114635] Remove files related to quota and proximity events from the Xcode project : [Attachment 198182] Patch

[bugzilla-daemon at webkit.org]

Benjamin Poulain <benjamin at webkit.org> has granted Anders Carlsson
<andersca at apple.com>'s request for review:
Bug 114635: Remove files related to quota and proximity events from the Xcode
project
https://bugs.webkit.org/show_bug.cgi?id=114635

Attachment 198182: Patch
https://bugs.webkit.org/attachment.cgi?id=198182&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=198182&action=review


> Source/WebCore/WebCore.xcodeproj/project.pbxproj:6839
> +		1ACF735D171C9A5B00C9BB1E /* DOMWindowQuota.h */ = {isa =
PBXFileReference; lastKnownFileType = sourcecode.c.h; path = DOMWindowQuota.h;
sourceTree = "<group>"; };
> +		1ACF7372171C9AD400C9BB1E /* NavigatorStorageQuota.h */ = {isa =
PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path =
NavigatorStorageQuota.h; sourceTree = "<group>"; };
> +		1ACF7374171C9B7F00C9BB1E /* WorkerNavigatorStorageQuota.h */ =
{isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h;
path = WorkerNavigatorStorageQuota.h; sourceTree = "<group>"; };

I think reinserting DOMWindowQuota.h and WorkerNavigatorStorageQuota.h could
cause issues on the iOS project file.

> Source/WebCore/WebCore.xcodeproj/project.pbxproj:20884
>				49E912AB0EFAC906009D0CAF /* Animation.h in
Headers */,
>				316FE1120E6E1DA700BF6088 /* AnimationBase.h in
Headers */,
> +				1ACF7375171C9B7F00C9BB1E /*
WorkerNavigatorStorageQuota.h in Headers */,
>				316FE1140E6E1DA700BF6088 /*
AnimationController.h in Headers */,

The file section should be sorted alphabetically.

> Source/WebCore/WebCore.xcodeproj/project.pbxproj:23713
>				B2C3DA420D006C1D00EF6F26 /* TextCodecUTF16.h in
Headers */,
> +				1ACF7373171C9AD400C9BB1E /*
NavigatorStorageQuota.h in Headers */,
>				9343CB8212F25E510033C5EE /* TextCodecUTF8.h in
Headers */,

The file section should be sorted alphabetically.