[webkit-reviews] review granted: [Bug 114549] Add private interface to WKView to asynchronously update the drawing area size : [Attachment 197915] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Gavin Barraclough
<barraclough at apple.com>'s request for review:
Bug 114549: Add private interface to WKView to asynchronously update the
drawing area size
https://bugs.webkit.org/show_bug.cgi?id=114549

Attachment 197915: Patch
https://bugs.webkit.org/attachment.cgi?id=197915&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=197915&action=review


> Source/WebKit2/UIProcess/API/mac/WKView.mm:3445
> +// The updated is performed asynchronously; we don't wait for the geometry
update before returning.

The update

> Source/WebKit2/UIProcess/API/mac/WKView.mm:3464
> +	   // If a geometry update is still pending then the action of
recieving the

receiving

> Source/WebKit2/UIProcess/API/mac/WKView.mm:3468
> +	   drawingArea->waitForPossibleGeometryUpdate();
> +	   drawingArea->waitForPossibleGeometryUpdate();

Do we really want to wait for a whole second?