[webkit-reviews] review granted: [Bug 113623] fourthTier: FTL should have OSR exit : [Attachment 197914] the patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Apr 12 19:04:09 PDT 2013


Oliver Hunt <oliver at apple.com> has granted Filip Pizlo <fpizlo at apple.com>'s
request for review:
Bug 113623: fourthTier: FTL should have OSR exit
https://bugs.webkit.org/show_bug.cgi?id=113623

Attachment 197914: the patch
https://bugs.webkit.org/attachment.cgi?id=197914&action=review

------- Additional Comments from Oliver Hunt <oliver at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=197914&action=review


> Source/JavaScriptCore/ftl/FTLExitThunkGenerator.cpp:53
> +    move(TrustedImm32(index), GPRInfo::nonArgGPR0);

I am dubious as to how trusted this is, but until i have evidence that we can
be coerced into planting a large number of these in succession i'll give it a
pass.


More information about the webkit-reviews mailing list