[webkit-reviews] review denied: [Bug 70592] [EFL][GTK] Share plugin's implementation between EFL and Gtk ports. : [Attachment 190511] updated patch

[bugzilla-daemon at webkit.org]

Philippe Normand <pnormand at igalia.com> has denied Mariusz Grzegorczyk
<mariusz.g at samsung.com>'s request for review:
Bug 70592: [EFL][GTK] Share plugin's implementation between EFL and Gtk ports.
https://bugs.webkit.org/show_bug.cgi?id=70592

Attachment 190511: updated patch
https://bugs.webkit.org/attachment.cgi?id=190511&action=review

------- Additional Comments from Philippe Normand <pnormand at igalia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=190511&action=review


> Source/WebCore/plugins/x11/PluginViewX11.cpp:78
> +#else

#elif PLATFORM(EFL)

> Source/WebCore/plugins/x11/PluginViewX11.cpp:145
> +#else

Ditto

> Source/WebCore/plugins/x11/PluginViewX11.cpp:680
> +#if PLATFORM(GTK)
> +	   *static_cast<uint32_t*>(value) = 2;
> +#else
> +	   *static_cast<uint32_t*>(value) = 0;
> +#endif

I don't understand this, I guess it's inherited from the previous PluginView
implementation but a comment would be good to have here. Also, mind turning the
#else to and #elif ?

> Source/WebCore/plugins/x11/PluginViewX11.cpp:687
> +#else

#elif PLATFORM(EFL)

> Source/WebCore/plugins/x11/PluginViewX11.cpp:994
> +#else

Ditto