[webkit-reviews] review granted: [Bug 114330] Refactor TextTrack and TextTrackList to make it easier to add audio and video tracks : [Attachment 197877] Patch

[bugzilla-daemon at webkit.org]

Jer Noble <jer.noble at apple.com> has granted Brendan Long
<b.long at cablelabs.com>'s request for review:
Bug 114330: Refactor TextTrack and TextTrackList to make it easier to add audio
and video tracks
https://bugs.webkit.org/show_bug.cgi?id=114330

Attachment 197877: Patch
https://bugs.webkit.org/attachment.cgi?id=197877&action=review

------- Additional Comments from Jer Noble <jer.noble at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=197877&action=review


r+, with nit:

> Source/WebCore/html/track/TextTrack.cpp:574
> +TextTrack* toTextTrack(TrackBase* track)
> +{
> +    ASSERT(track->type() == TrackBase::TextTrack);
> +    return static_cast<TextTrack*>(track);
>  }

Nit: please put the body of this function into the header file, so it can be
inlined.

(If you don't have committer rights, just upload a new patch named "Patch for
Committing" and either Eric or I will cq+ it.)