[webkit-reviews] review requested: [Bug 112929] [CSS Exclusions] Increasing padding does not correctly layout child blocks : [Attachment 197317] proposed patch, header fixed
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Apr 10 11:13:23 PDT 2013
Zoltan Horvath <zoltan at webkit.org> has asked for review:
Bug 112929: [CSS Exclusions] Increasing padding does not correctly layout child
blocks
https://bugs.webkit.org/show_bug.cgi?id=112929
Attachment 197317: proposed patch, header fixed
https://bugs.webkit.org/attachment.cgi?id=197317&action=review
------- Additional Comments from Zoltan Horvath <zoltan at webkit.org>
> > Source/WebCore/rendering/RenderBlock.h:582
> > + void updateRegionsAndExclusionsAfterChildLayout(RenderFlowThread*,
bool = false);
>
> You need to include the parameter name here, since it's not clear what the
boolean means without it.
Fixed.
More information about the webkit-reviews
mailing list