[webkit-reviews] review denied: [Bug 112929] [CSS Exclusions] Increasing padding does not correctly layout child blocks : [Attachment 197307] proposed patch

[bugzilla-daemon at webkit.org]

Dave Hyatt <hyatt at apple.com> has denied Zoltan Horvath <zoltan at webkit.org>'s
request for review:
Bug 112929: [CSS Exclusions] Increasing padding does not correctly layout child
blocks
https://bugs.webkit.org/show_bug.cgi?id=112929

Attachment 197307: proposed patch
https://bugs.webkit.org/attachment.cgi?id=197307&action=review

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=197307&action=review


Looks good, just fix the header file.

> Source/WebCore/rendering/RenderBlock.h:582
> +    void updateRegionsAndExclusionsAfterChildLayout(RenderFlowThread*, bool
= false);

You need to include the parameter name here, since it's not clear what the
boolean means without it.