[webkit-reviews] review granted: [Bug 114062] If CallFrame::trueCallFrame() knows that it's about to read garbage instead of a valid CodeOrigin/InlineCallFrame, then it should give up and return 0 and all callers should be robust against this : [Attachment 196680] the patch

[bugzilla-daemon at webkit.org]

Oliver Hunt <oliver at apple.com> has granted Filip Pizlo <fpizlo at apple.com>'s
request for review:
Bug 114062: If CallFrame::trueCallFrame() knows that it's about to read garbage
instead of a valid CodeOrigin/InlineCallFrame, then it should give up and
return 0 and all callers should be robust against this
https://bugs.webkit.org/show_bug.cgi?id=114062

Attachment 196680: the patch
https://bugs.webkit.org/attachment.cgi?id=196680&action=review

------- Additional Comments from Oliver Hunt <oliver at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=196680&action=review


> Source/JavaScriptCore/interpreter/CallFrame.cpp:124
>	   ASSERT_UNUSED(hasCodeOrigin, hasCodeOrigin);

This can just change to ASSERT() as we use hasCodeOrigin now