[webkit-reviews] review denied: [Bug 13709] Table border doesn't show up : [Attachment 196661] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has denied Suchit Agrawal
<a.suchit at samsung.com>'s request for review:
Bug 13709: Table border doesn't show up
https://bugs.webkit.org/show_bug.cgi?id=13709

Attachment 196661: Patch
https://bugs.webkit.org/attachment.cgi?id=196661&action=review

------- Additional Comments from Antti Koivisto <koivisto at iki.fi>
View in context: https://bugs.webkit.org/attachment.cgi?id=196661&action=review


> Source/WebCore/css/StyleBuilder.cpp:668
> +	   // note: CSSPropertyLetter/WordSpacing right now sets to zero if
it's not a primitive value for some reason...

I don't know what this comment means but it shouldn't be anywhere else than
ApplyPropertyComputeTextSpacing.

> LayoutTests/ChangeLog:11
> +	   This test file have border width, outline offset, outline width,
border
> +	   spacing and column rule width properties test cases.
> +	   * fast/borders/border-width-less-then-a-unit-of-pt-expected.html:
Added.
> +	   * fast/borders/border-width-less-then-a-unit-of-pt.html: Added.

You still need to update the test result for
tables/mozilla_expected_failures/bugs/bug89315.html