[webkit-reviews] review denied: [Bug 113954] Regression(r147639) Causes assertion hit in HashTable : [Attachment 196514] Patch

[bugzilla-daemon at webkit.org]

Benjamin Poulain <benjamin at webkit.org> has denied Christophe Dumez
<dchris at gmail.com>'s request for review:
Bug 113954: Regression(r147639) Causes assertion hit in HashTable
https://bugs.webkit.org/show_bug.cgi?id=113954

Attachment 196514: Patch
https://bugs.webkit.org/attachment.cgi?id=196514&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=196514&action=review


This is not making recursive use safer:

> Source/WebCore/platform/graphics/FontCache.cpp:207
> +    OwnPtr<FontPlatformData>& value = result.iterator->value;

This reference will be okay in the majority of cases.
But...if the table grows or shrink, you are no pointing to the right object.