[webkit-reviews] review denied: [Bug 112929] [CSS Exclusions] Increasing padding does not correctly layout child blocks : [Attachment 196499] proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 4 13:40:07 PDT 2013


Dave Hyatt <hyatt at apple.com> has denied Zoltan Horvath <zoltan at webkit.org>'s
request for review:
Bug 112929: [CSS Exclusions] Increasing padding does not correctly layout child
blocks
https://bugs.webkit.org/show_bug.cgi?id=112929

Attachment 196499: proposed patch
https://bugs.webkit.org/attachment.cgi?id=196499&action=review

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
All the animation code does is repeatedly change padding-top, so it seems like
you're just working around a bug here. If you re-write the test case to
manually set padding-top over and over using setTimeout instead of using an
animation, won't it just still fail? I don't see why animation has anything to
do with the bug. It's just how you happened to build the test case.


More information about the webkit-reviews mailing list