[webkit-reviews] review denied: [Bug 113398] Web Inspector: add event for node inspection request while in inspection mode : [Attachment 196109] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Dmitry Gozman
<dgozman at chromium.org>'s request for review:
Bug 113398: Web Inspector: add event for node inspection request while in
inspection mode
https://bugs.webkit.org/show_bug.cgi?id=113398

Attachment 196109: Patch
https://bugs.webkit.org/attachment.cgi?id=196109&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=196109&action=review


> Source/WebCore/inspector/Inspector.json:2074
> +		   "name": "nodeShouldBeInspected",

inspectNodeRequested

> Source/WebCore/inspector/InspectorDOMAgent.cpp:1033
> +    if (m_searchingForNode) {

Lets remove this "focusNode" method - it is misleading.

> Source/WebCore/inspector/front-end/DOMAgent.js:1050
> +	   WebInspector.updateFocusedNode(nodeId);

DOMAgent is SDK, WebInspector is UI, no dependency is allowed.