[webkit-reviews] review granted: [Bug 113708] Web Inspector: [Timeline] unify logic for 3 overview modes in Timeline : [Attachment 195984] Patch

[bugzilla-daemon at webkit.org]

Yury Semikhatsky <yurys at chromium.org> has granted Andrey Kosyakov
<caseq at chromium.org>'s request for review:
Bug 113708: Web Inspector: [Timeline] unify logic for 3 overview modes in
Timeline
https://bugs.webkit.org/show_bug.cgi?id=113708

Attachment 195984: Patch
https://bugs.webkit.org/attachment.cgi?id=195984&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=195984&action=review


> Source/WebCore/inspector/front-end/TimelineOverviewPane.js:148
> +	   return null;

Why not just throw if the mode is invalid, you would anyway fail on the first
attempt to call a method on the controll at line 131?