[webkit-reviews] review granted: [Bug 113743] Viewport constrained elements should work properly with headers and footers : [Attachment 196068] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Beth Dakin
<bdakin at apple.com>'s request for review:
Bug 113743: Viewport constrained elements should work properly with headers and
footers
https://bugs.webkit.org/show_bug.cgi?id=113743

Attachment 196068: Patch
https://bugs.webkit.org/attachment.cgi?id=196068&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=196068&action=review


> Source/WebCore/page/scrolling/ScrollingStateScrollingNode.h:112
> +    unsigned headerHeight() const { return m_headerHeight; }

int return.

> Source/WebCore/page/scrolling/ScrollingStateScrollingNode.h:115
> +    unsigned footerHeight() const { return m_footerHeight; }

Ditto.

> Source/WebCore/page/scrolling/ScrollingStateScrollingNode.h:161
> +    unsigned m_headerHeight;
> +    unsigned m_footerHeight;

int?

> Source/WebCore/page/scrolling/ScrollingTreeScrollingNode.h:77
> +    unsigned headerHeight() const { return m_headerHeight; }
> +    unsigned footerHeight() const { return m_footerHeight; }

ints

> Source/WebCore/page/scrolling/ScrollingTreeScrollingNode.h:98
> +    unsigned m_headerHeight;
> +    unsigned m_footerHeight;

ints

> Source/WebCore/page/scrolling/mac/ScrollingCoordinatorMac.h:119
> +	   unsigned headerHeight;
> +	   unsigned footerHeight;

ints

>
LayoutTests/platform/mac-wk2/tiled-drawing/fixed/four-bars-with-header-and-foot
er.html:5
> +    <meta name="apple-mobile-web-app-capable" content="yes">

Remove this.

>
LayoutTests/platform/mac-wk2/tiled-drawing/fixed/four-bars-with-header-and-foot
er.html:47
> +    <script type="text/javascript" charset="utf-8">

No need for the attributes.