[webkit-reviews] review denied: [Bug 110717] [EFL] Consolidate defaults for feature flags : [Attachment 193455] move the computation out to a macro

[bugzilla-daemon at webkit.org]

Daniel Bates <dbates at webkit.org> has denied  review:
Bug 110717: [EFL] Consolidate defaults for feature flags
https://bugs.webkit.org/show_bug.cgi?id=110717

Attachment 193455: move the computation out to a macro
https://bugs.webkit.org/attachment.cgi?id=193455&action=review

------- Additional Comments from Daniel Bates <dbates at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=193455&action=review


> Tools/Scripts/build-webkit:96
> +    my $Definitions = `gcc -E -P -dM -D$portDefine -I Source/WTF
Source/WTF/wtf/Platform.h | grep '^#define ENABLE_\\w\\+ \[01\]\$\\|^#define
WTF_USE_\\w\\+ \[01\]\$' | cut -d' ' -f2-3`;

I wish there was a better way to do this. We follow the WebKit Code Style
Conventions for Perl code. So, variable names should be in CamelCase and begin
with a lowercase letter.

> Tools/Scripts/build-webkit:99
> +    my %FeatureDefaults;    

As mentioned above, variable names should be in CamelCase and begin with a
lowercase letter.

> Tools/Scripts/build-webkit:100
> +    foreach (split(/\n/, $Definitions)) {

Ditto.

> Tools/Scripts/build-webkit:101
> +	   my @MacroDefinition = split(/ /);

Ditto.

> Tools/Scripts/build-webkit:102
> +	   $FeatureDefaults{$MacroDefinition[0]} = $MacroDefinition[1];

Ditto.

> Tools/Scripts/build-webkit:106
> +	   if (exists $FeatureDefaults{$_->{define}}) {

Ditto.