[webkit-reviews] review denied: [Bug 97641] Web Inspector: compare objects counted by the memory instrumentation with those allocated in the heap : [Attachment 165753] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Yury Semikhatsky
<yurys at chromium.org>'s request for review:
Bug 97641: Web Inspector: compare objects counted by the memory instrumentation
with those allocated in the heap
https://bugs.webkit.org/show_bug.cgi?id=97641

Attachment 165753: Patch
https://bugs.webkit.org/attachment.cgi?id=165753&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=165753&action=review


> Source/WTF/wtf/MemoryInstrumentation.h:110
> +#if ENABLE(DEBUG_MEMORY_INSTRUMENTATION)

I would only guard the backing implementation for better readability.

> Source/WebCore/inspector/InspectorClient.h:75
> +#if ENABLE(DEBUG_MEMORY_INSTRUMENTATION)

I would even remove this guard.

> Source/WebCore/inspector/MemoryInstrumentationImpl.cpp:86
> +    if (!m_allocatedObjects.contains(object)) {

You could only consider non-empty arrays valid.