[webkit-reviews] review denied: [Bug 97633] [Forms] Adding localization texts for multiple fields date/time input UI : [Attachment 165757] Patch 3

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has denied yosin at chromium.org's request for
review:
Bug 97633: [Forms] Adding localization texts for multiple fields date/time
input UI
https://bugs.webkit.org/show_bug.cgi?id=97633

Attachment 165757: Patch 3
https://bugs.webkit.org/attachment.cgi?id=165757&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=165757&action=review


> Source/WebKit/chromium/ChangeLog:15
> +	   (WebCore::dateFormatHelpLetters): Added for DateInputType,
DateTimeInputType, and DateTimeLocalInputType to provide threeletters, e.g.
"ymd" for English, for indicating order of day, month and year fields to
display them intead of "-" when field has empty value.

threeletters -> three letters?
Is "年" one letter? Should we count a character of which code point is greater
than U+FFFF as one letter? How about Unicode composition?

> Source/WebKit/chromium/ChangeLog:16
> +	   (WebCore::dateFormatHelpText): Added for DateInputType,
DateTimeInputType, and DateTimeLocalInputType to provide help text of order of
day, month and year fields.

still unclear.	In what situation a user will see this text? What text is
expected?