[webkit-reviews] review denied: [Bug 97076] [BlackBerry] Empty URL gets through to acceptNavigationRequest() : [Attachment 164674] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Sep 25 23:00:41 PDT 2012


George Staikos <staikos at kde.org> has denied Charles Wei
<charles.wei at torchmobile.com.cn>'s request for review:
Bug 97076: [BlackBerry] Empty URL gets through to acceptNavigationRequest()
https://bugs.webkit.org/show_bug.cgi?id=97076

Attachment 164674: Patch
https://bugs.webkit.org/attachment.cgi?id=164674&action=review

------- Additional Comments from George Staikos <staikos at kde.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=164674&action=review


r- to make the diff smaller.

> Source/WebKit/blackberry/WebCoreSupport/FrameLoaderClientBlackBerry.cpp:221
> +	   if (!platformRequest.getUrlRef().empty()) { // Some invalid URLs
will result in empty URL in platformRequest

Let's make this an early return instead?


More information about the webkit-reviews mailing list