[webkit-reviews] review granted: [Bug 94397] Web Inspector: expose object internal properties such as PrimitiveValue or BoundThis : [Attachment 165655] Patch

[bugzilla-daemon at webkit.org]

Yury Semikhatsky <yurys at chromium.org> has granted Peter Rybin
<prybin at chromium.org>'s request for review:
Bug 94397: Web Inspector: expose object internal properties such as
PrimitiveValue or BoundThis
https://bugs.webkit.org/show_bug.cgi?id=94397

Attachment 165655: Patch
https://bugs.webkit.org/attachment.cgi?id=165655&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=165655&action=review


> LayoutTests/inspector-protocol/runtime-getProperties-expected.txt:1
> +Properties of Object(5)

You will also need to provide JSC-specific test expectations.

> LayoutTests/inspector-protocol/runtime-getProperties.html:50
> +		   processStep(next);

Consider moving this into the try block.

> LayoutTests/inspector-protocol/runtime-getProperties.html:90
> +	   if (id === undefined)

if (!id) would work