[webkit-reviews] review granted: [Bug 97460] [GTK] Add Select All method to WebKit2 GTK+ API : [Attachment 165400] Patch

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has granted Simon Pena
<spena at igalia.com>'s request for review:
Bug 97460: [GTK] Add Select All method to WebKit2 GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=97460

Attachment 165400: Patch
https://bugs.webkit.org/attachment.cgi?id=165400&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=165400&action=review


Nice work. The tests you have written are more than adequate, in my opinion. I
just have a few minor nits. Do you mind just uploading a new patch and then I
can commit it for you.

> Source/WebKit2/UIProcess/API/gtk/tests/TestWebViewEditor.cpp:59
> +    void executeEditingCommand(const char* command)
> +    {
> +	   webkit_web_view_execute_editing_command(m_webView, command);
> +    }
> +

Since this method just does one thing, it probably makes a bit more sense just
do call webkit_web_view_execute_editing_command from the test. It makes it a
bit more clear what API you are actually testing there.

> Source/WebKit2/UIProcess/API/gtk/tests/TestWebViewEditor.cpp:157
> +    // Initially only the subspan is selected

Just a minor nit here. Comments in WebKit should have a period at the end.