[webkit-reviews] review denied: [Bug 73885] DOM4 remove method : [Attachment 165403] Patch

[bugzilla-daemon at webkit.org]

Ojan Vafai <ojan at chromium.org> has denied Erik Arvidsson <arv at chromium.org>'s
request for review:
Bug 73885: DOM4 remove method
https://bugs.webkit.org/show_bug.cgi?id=73885

Attachment 165403: Patch
https://bugs.webkit.org/attachment.cgi?id=165403&action=review

------- Additional Comments from Ojan Vafai <ojan at chromium.org>
I think you can get exceptions in all these cases due to sync firing of
mutation events and blur/focus events. All the places in the existing code that
ASSERT(!ec) are just wrong. Some day, I'll like for us to try an experiment
where we EventScope blur/focus events as well and see if pages break, but until
then, remove can throw exceptions. You obviously don't need to fixup the
existing code, but I think we need to make the DOM4 method throw in the case
that the child has been moved (e.g. during a blur event).