[webkit-reviews] review granted: [Bug 91844] [WK2][GTK][EFL] Share WebKit2-GTK plugin process implementation with EFL port : [Attachment 164889] Fixes webkit style

[bugzilla-daemon at webkit.org]

Simon Hausmann <hausmann at webkit.org> has granted Mariusz Grzegorczyk
<mariusz.g at samsung.com>'s request for review:
Bug 91844: [WK2][GTK][EFL] Share WebKit2-GTK plugin process implementation with
EFL port
https://bugs.webkit.org/show_bug.cgi?id=91844

Attachment 164889: Fixes webkit style
https://bugs.webkit.org/attachment.cgi?id=164889&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=164889&action=review


> Source/WebKit2/WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:106
> +#elif PLATFORM(EFL) && defined(HAVE_ECORE_X)
> +    return ecore_x_screen_index_get(ecore_x_default_screen_get());

I still think that this kind of stuff can easily be simplified to use Xlib
functions (see PLATFORM(QT) code path), given a platform-specific way of
getting the X display. But that can be done in a separate patch if you'd like.