[webkit-reviews] review denied: [Bug 97272] Web Inspector: Catch exceptions in JavaScriptSource workingCopyCommit : [Attachment 165013] Patch

[bugzilla-daemon at webkit.org]

Vsevolod Vlasov <vsevik at chromium.org> has denied johnjbarton
<johnjbarton at chromium.org>'s request for review:
Bug 97272: Web Inspector: Catch exceptions in JavaScriptSource
workingCopyCommit
https://bugs.webkit.org/show_bug.cgi?id=97272

Attachment 165013: Patch
https://bugs.webkit.org/attachment.cgi?id=165013&action=review

------- Additional Comments from Vsevolod Vlasov <vsevik at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=165013&action=review


> Source/WebCore/inspector/front-end/JavaScriptSource.js:104
> +	       var rawLocation = this.uiLocationToRawLocation(0, 0);

We try to avoid exceptions in inspector code.
Why not use 
if (!rawLocation)
    return;
instead?

> LayoutTests/inspector/debugger/live-edit.html:14
> +    WebInspector.showPanel("scripts");

var panel = WebInspector.showPanel("scripts");