[webkit-reviews] review granted: [Bug 96168] WebKit exposes incorrect bounds for embedded SVG in HTML : [Attachment 165144] patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted chris fleizach
<cfleizach at apple.com>'s request for review:
Bug 96168: WebKit exposes incorrect bounds for embedded SVG in HTML
https://bugs.webkit.org/show_bug.cgi?id=96168

Attachment 165144: patch 
https://bugs.webkit.org/attachment.cgi?id=165144&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=165144&action=review


> Source/WebCore/rendering/svg/RenderSVGModelObject.cpp:169
> +void RenderSVGModelObject::absoluteFocusRingQuads(Vector<FloatQuad>& quads)

FYI. Almost all SVG objects are SVGModelObjects, except RenderSVGBlock (for
<text>, <tspan> etc.) and RenderForeignObject.	If you worry about those
bounds, you may need to test them as well in your test case to be sure.