[webkit-reviews] review denied: [Bug 95193] Implement the GetStats interface on PeerConnection : [Attachment 165126] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has denied Harald Alvestrand <hta at google.com>'s
request for review:
Bug 95193: Implement the GetStats interface on PeerConnection
https://bugs.webkit.org/show_bug.cgi?id=95193

Attachment 165126: Patch
https://bugs.webkit.org/attachment.cgi?id=165126&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=165126&action=review


This basically looks good.  Is there a reason why you're not using
sequence<Foo> instead of creating these fake DOM-based arrays?	Also, it looks
like the patch doesn't compile, perhaps because it is missing the CPP file
noted below.

> Source/Platform/chromium/public/WebRTCStatsRequest.h:60
> +    WEBKIT_EXPORT void requestSucceeded() const;

Don't we need to supply some stats somehow?

> Source/WebCore/Modules/mediastream/RTCPeerConnection.h:89
> +    void getStats(PassRefPtr<RTCStatsCallback>,
PassRefPtr<MediaStreamTrack>);

I would have given these parameters names since it's not clear what they mean
otherwise.

> Source/WebCore/Modules/mediastream/RTCPeerConnection.idl:75
> +	   void getStats(in [Callback] RTCStatsCallback successCallback, in
[Optional=DefaultIsUndefined] MediaStreamTrack selector);

Do you have a link to the spec handy?

> Source/WebCore/Modules/mediastream/RTCStatsElement.idl:31
> +	   // name "value" causes an error

What does this comment mean?

> Source/WebCore/Modules/mediastream/RTCStatsElementList.h:39
> +    // DOM methods & attributes for RTCStatsElementList

This comment isn't needed.

> Source/WebCore/Modules/mediastream/RTCStatsReport.h:32
> +class RTCStatsReport : public RefCounted<RTCStatsReport> {

I still don't see RTCStatsReport.cpp in this patch.  Is that what's causing the
compile error?