[webkit-reviews] review granted: [Bug 97214] [Qt] Abstract as much devicePixelRatio logic as possible behind PageViewportController : [Attachment 164918] Patch

[bugzilla-daemon at webkit.org]

Kenneth Rohde Christiansen <kenneth at webkit.org> has granted Jocelyn Turcotte
<jocelyn.turcotte at digia.com>'s request for review:
Bug 97214: [Qt] Abstract as much devicePixelRatio logic as possible behind
PageViewportController
https://bugs.webkit.org/show_bug.cgi?id=97214

Attachment 164918: Patch
https://bugs.webkit.org/attachment.cgi?id=164918&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=164918&action=review


> Source/WebKit2/ChangeLog:21
> +	   Other related changes:
> +	   - Make sure that the controller and it's client are only exchanging
effective scales
> +	   (cssScale * devicePixelRatio)
> +	   - Remove members duplicating m_rawAttributes values
> +	   - Use a separate member for the minimum scale to fit the page,
separate from the viewport arguments
> +	   - Make sure that the minimum scale to fit is adjusted if the
contents size isn't
> +	     updated after the viewport attributes changed
> +	   - Make the scale conversion functions private to discourage this
logic from spreading in the client
> +

nice!

> Source/WebKit2/UIProcess/PageViewportController.h:87
> +    float devicePixelRatio() const { return
m_rawAttributes.devicePixelRatio; }

FYI devicePixelRatio should be removed from ViewportAttributes and gotten from
elsewhere, it just havent been done yet

> Source/WebKit2/UIProcess/PageViewportController.h:115
> +    float m_minimumScaleToFit;

so this is viewort scale? m_minimumViewportScaleToFit?