[webkit-reviews] review granted: [Bug 97215] [Qt] Make sure that desktop pages honour the devicePixelRatio : [Attachment 164921] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Sep 20 23:32:42 PDT 2012


Kenneth Rohde Christiansen <kenneth at webkit.org> has granted Jocelyn Turcotte
<jocelyn.turcotte at digia.com>'s request for review:
Bug 97215: [Qt] Make sure that desktop pages honour the devicePixelRatio
https://bugs.webkit.org/show_bug.cgi?id=97215

Attachment 164921: Patch
https://bugs.webkit.org/attachment.cgi?id=164921&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=164921&action=review


> Source/WebKit2/WebProcess/WebPage/WebPage.cpp:943
> +    int minimumLayoutFallbackWidth =
std::max(settings->layoutFallbackWidth(), int(m_viewportSize.width() /
m_page->deviceScaleFactor()));

so maybe ceil or lrint would make more sense?


More information about the webkit-reviews mailing list