[webkit-reviews] review denied: [Bug 95238] [skia] Switch FEComponentTransfer to use skia's SkColorFilter : [Attachment 161223] Patch

[bugzilla-daemon at webkit.org]

Stephen Chenney <schenney at chromium.org> has denied Stephen White
<senorblanco at chromium.org>'s request for review:
Bug 95238: [skia] Switch FEComponentTransfer to use skia's SkColorFilter
https://bugs.webkit.org/show_bug.cgi?id=95238

Attachment 161223: Patch
https://bugs.webkit.org/attachment.cgi?id=161223&action=review

------- Additional Comments from Stephen Chenney <schenney at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=161223&action=review


> Source/WebCore/platform/graphics/filters/FEComponentTransfer.h:83
> +    virtual bool platformApplySkia();

Where is this actually called? Did the patch fail to pick up a changed file? If
this is a preparatory patch then the test expectations shouldn't be updated.

> Source/WebCore/platform/graphics/filters/skia/FEComponentTransferSkia.cpp:39
> +    if (!in) 

This is only invoked if there is an inputEffect, so no need to check this.