[webkit-reviews] review granted: [Bug 96033] IndexedDB: IDBObjectStore.count() is slow : [Attachment 163397] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Sep 11 10:43:46 PDT 2012


Tony Chang <tony at chromium.org> has granted Joshua Bell <jsbell at chromium.org>'s
request for review:
Bug 96033: IndexedDB: IDBObjectStore.count() is slow
https://bugs.webkit.org/show_bug.cgi?id=96033

Attachment 163397: Patch
https://bugs.webkit.org/attachment.cgi?id=163397&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=163397&action=review


> Source/WebCore/Modules/indexeddb/IDBLevelDBBackingStore.cpp:1358
> +    const char* p = m_iterator->key().begin();

Nit: Can you pick better variable names than p and q? Maybe key and value or
currentKey and currentValue?


More information about the webkit-reviews mailing list