[webkit-reviews] review granted: [Bug 96126] Appcache fallback URL match should use the longest candidate : [Attachment 162855] Patch v4

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Sep 7 13:42:31 PDT 2012


Alexey Proskuryakov <ap at webkit.org> has granted Leo Yang <leoyang at rim.com>'s
request for review:
Bug 96126: Appcache fallback URL match should use the longest candidate
https://bugs.webkit.org/show_bug.cgi?id=96126

Attachment 162855: Patch v4
https://bugs.webkit.org/attachment.cgi?id=162855&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=162855&action=review


Thank you for updating the patch!

> Source/WebCore/loader/appcache/ApplicationCache.cpp:169
> +    std::stable_sort(m_fallbackURLs.begin(), m_fallbackURLs.end(),
&fallbackURLLongerThan);

Sorry, I didn't notice this at first. Please remove the "&" sign.


More information about the webkit-reviews mailing list