[webkit-reviews] review denied: [Bug 96125] StringImpl::find(StringImpl*) doesn't handle cases where search and match strings are different bitness : [Attachment 162818] Patch with Tab character removed from ChangeLog

[bugzilla-daemon at webkit.org]

Benjamin Poulain <benjamin at webkit.org> has denied Michael Saboff
<msaboff at apple.com>'s request for review:
Bug 96125: StringImpl::find(StringImpl*) doesn't handle cases where search and
match strings are different bitness
https://bugs.webkit.org/show_bug.cgi?id=96125

Attachment 162818: Patch with Tab character removed from ChangeLog
https://bugs.webkit.org/attachment.cgi?id=162818&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=162818&action=review


r- for the the other find().

Why not update find(StringImpl* matchString, unsigned index) similarly?

> Source/WTF/wtf/text/StringImpl.cpp:971
> -    while (searchHash != matchHash || memcmp(searchCharacters + i,
matchCharacters, matchLength * sizeof(CharType))) {
> +    while (searchHash != matchHash || !equal(searchCharacters + i,
matchCharacters, matchLength)) {

This may causes regressions, although that is unlikely for the length we use
with find().