[webkit-reviews] review granted: [Bug 95997] [chromium] Add touchscreen specific fling curve parametrization : [Attachment 162824] Patch

[bugzilla-daemon at webkit.org]

James Robinson <jamesr at chromium.org> has granted Robert Kroeger
<rjkroege at chromium.org>'s request for review:
Bug 95997: [chromium] Add touchscreen specific fling curve parametrization
https://bugs.webkit.org/show_bug.cgi?id=95997

Attachment 162824: Patch
https://bugs.webkit.org/attachment.cgi?id=162824&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=162824&action=review


> Source/WebCore/platform/TouchFlingPlatformGestureCurve.cpp:69
> +// the in-flight patch for https://bugs.webkit.org/show_bug.cgi?id=81663 .

I know you're just moving this code but this FIXME and comment are sad. 
https://bugs.webkit.org/show_bug.cgi?id=81663 was abandoned a while ago, do we
still need these extra parameters?

> Source/WebCore/platform/TouchFlingPlatformGestureCurve.h:56
> +    float m_coeffs[5];

No abbreviations in webkit

> Source/WebCore/platform/TouchFlingPlatformGestureCurve.h:61
> +    static const int m_maxSearchIterations;

Statics shouldn't have the m_ prefix. This probably doesn't should be a member
at all - just make it a static const local in the function it's being used in,
or a file-static if it's used in multiple places