[webkit-reviews] review denied: [Bug 95885] [chromium] Add new accelerated overflow scroll setting. : [Attachment 162829] Patch

[bugzilla-daemon at webkit.org]

James Robinson <jamesr at chromium.org> has denied Glenn Hartmann
<hartmanng at chromium.org>'s request for review:
Bug 95885: [chromium] Add new accelerated overflow scroll setting.
https://bugs.webkit.org/show_bug.cgi?id=95885

Attachment 162829: Patch
https://bugs.webkit.org/attachment.cgi?id=162829&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=162829&action=review


> Source/Platform/ChangeLog:13
> +	   * chromium/public/WebTransformOperations.h:
> +	   (WebTransformOperations):
> +	   * chromium/public/WebTransformationMatrix.h:
> +	   (WebTransformationMatrix):

Are you really patching WebTransformOperations and WebTransformationMatrix?  I
think you need to regenerate changelogs (or at least delete this entry)

> Source/WebCore/ChangeLog:8
> +	   Add new accelerated overflow scroll setting, as required for 94743.

This isn't really describing anything.	You should say what this setting does
and what it's for (and "for 94743" does not explain anything).

> Source/WebCore/page/Settings.h:127
> +	   void setEnableAcceleratedOverflowScroll(bool);

This should follow the other compositor trigger settings and be close to them. 
For example:

setAcceleratedCompositingForFixedPositionEnabled
setAcceleratedCompositingForScrollableFramesEnabled

etc