[webkit-reviews] review requested: [Bug 96066] [BlackBerry] Removing String operator += uses in BlackBerry code : [Attachment 162728] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Sep 7 03:35:40 PDT 2012


Sean Wang <xuewen.wang at torchmobile.com.cn> has asked  for review:
Bug 96066: [BlackBerry] Removing String operator += uses in BlackBerry code
https://bugs.webkit.org/show_bug.cgi?id=96066

Attachment 162728: patch
https://bugs.webkit.org/attachment.cgi?id=162728&action=review

------- Additional Comments from Sean Wang <xuewen.wang at torchmobile.com.cn>
I changed to use StringBuilder instead of operator +() to replace the operator
+=().
I do it on upstream repo directly. Since most of these file are not synchronous
with blackberry trunk, I have not gotten a change to build and verify them.
Should I sync these file to blackberry trunk and have test before push it?


More information about the webkit-reviews mailing list