[webkit-reviews] review denied: [Bug 96085] Datalist UI for input type=date for Chromium port : [Attachment 162723] Patch

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has denied Keishi Hattori
<keishi at webkit.org>'s request for review:
Bug 96085: Datalist UI for input type=date for Chromium port
https://bugs.webkit.org/show_bug.cgi?id=96085

Attachment 162723: Patch
https://bugs.webkit.org/attachment.cgi?id=162723&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=162723&action=review


> Source/WebCore/ChangeLog:69
> +2012-09-05  Keishi Hattori  <keishi at webkit.org>

Two ChangeLog entries

> Source/WebCore/Resources/pagepopups/pickerCommon.js:53
> +    console.log(width + "-" + height);

Remove debug code

> Source/WebCore/html/DateInputType.cpp:148
> +    Document* document = element()->document();
> +    RefPtr<RenderTheme> theme = document->page() ? document->page()->theme()
: RenderTheme::defaultTheme();
> +    if (theme->f4OpensDateTimeChooser() && event->keyIdentifier() == "F4") {

> +	   if (m_pickerElement)
> +	       m_pickerElement->openPopup();
> +	   event->setDefaultHandled();
> +	   return;
> +    }

Opening by F4 should be a separated patch.

> Source/WebCore/rendering/RenderTheme.h:239
> +    virtual bool f4OpensDateTimeChooser() const;

The function name looks really strange.  How about
opensDateTimeChooserByF4Key()?

> Source/WebKit/chromium/src/DateTimeChooserImpl.cpp:115
> +	   addProperty("showOtherDateEntry", m_parameters.type == "date",
writer);

Use InputTypeNames::date()

BTW, I think we had better split InputTypeNames out from InputType.{cpp.h}
because InputType is internal class for HTMLInputElement.

> Source/WebKit/chromium/src/DateTimeChooserImpl.cpp:116
> +	   addProperty("otherDateLabel",
Platform::current()->queryLocalizedString(WebLocalizedString::OtherColorLabel),
writer);

Using Other*Color*Label() is not appropriate.

> LayoutTests/ChangeLog:12
> +2012-09-05  Keishi Hattori  <keishi at webkit.org>

Two ChangeLog entries