[webkit-reviews] review denied: [Bug 95536] Make compile with both OS(WINCE) and PLATFORM(QT) support : [Attachment 162038] Patch (really fixed whitespace issues)

[bugzilla-daemon at webkit.org]

Patrick R. Gansterer <paroga at paroga.com> has denied Kevin Funk
<kevin.funk at kdab.com>'s request for review:
Bug 95536: Make compile with both OS(WINCE) and PLATFORM(QT) support
https://bugs.webkit.org/show_bug.cgi?id=95536

Attachment 162038: Patch (really fixed whitespace issues)
https://bugs.webkit.org/attachment.cgi?id=162038&action=review

------- Additional Comments from Patrick R. Gansterer <paroga at paroga.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=162038&action=review


> Source/WTF/wtf/unicode/icu/CollatorICU.cpp:45
> +#define strdup _strdup

please include <wtf/StringExtras.h> instead (outside of OS(WINCE)). It
implements this logic already.

> Source/WebCore/platform/win/ClipboardUtilitiesWin.cpp:36
> +#if !OS(WINCE)
>  #include <shlwapi.h>
> +#endif

please move conditional includes after the regular ones