[webkit-reviews] review granted: [Bug 95573] [chromium] WebGestureEvent deltaX/deltaY fields are overloaded : [Attachment 162037] Update bug number in ChangeLog

[bugzilla-daemon at webkit.org]

James Robinson <jamesr at chromium.org> has granted Rick Byers
<rbyers at chromium.org>'s request for review:
Bug 95573: [chromium] WebGestureEvent deltaX/deltaY fields are overloaded
https://bugs.webkit.org/show_bug.cgi?id=95573

Attachment 162037: Update bug number in ChangeLog
https://bugs.webkit.org/attachment.cgi?id=162037&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=162037&action=review


> Tools/DumpRenderTree/chromium/TestRunner/EventSender.cpp:1159
> +	   event.data.scrollUpdate.deltaX =
> +	       static_cast<float>(arguments[0].toDouble());
> +	   event.data.scrollUpdate.deltaY =
> +	       static_cast<float>(arguments[1].toDouble());

no need to line wrap - this is WebKit

> Tools/DumpRenderTree/chromium/TestRunner/EventSender.cpp:1178
> +	       event.data.tap.tapCount =
> +		   static_cast<float>(arguments[2].toDouble());

no line wrapping here

> Tools/DumpRenderTree/chromium/TestRunner/EventSender.cpp:1240
> +    event.data.flingStart.velocityX =
> +	   static_cast<float>(arguments[2].toDouble());
> +    event.data.flingStart.velocityY =
> +	   static_cast<float>(arguments[3].toDouble());

same