[webkit-reviews] review granted: [Bug 95703] [GTK] Print API missing documentation when generating gtkdoc : [Attachment 161953] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Sep 4 00:03:50 PDT 2012


Carlos Garcia Campos <cgarcia at igalia.com> has granted Martin Robinson
<mrobinson at webkit.org>'s request for review:
Bug 95703: [GTK] Print API missing documentation when generating gtkdoc
https://bugs.webkit.org/show_bug.cgi?id=95703

Attachment 161953: Patch
https://bugs.webkit.org/attachment.cgi?id=161953&action=review

------- Additional Comments from Carlos Garcia Campos <cgarcia at igalia.com>
Patch looks good to me, but it seems there are two independent changes, one is
raising an exception when rebase is called before doc is generated, instead of
just showing a message, I guess to make sure the script fails in such case,
because the exception is not handled. And the other change is showing missing
api when errors are reported. You could you split the patch before landing,
please?


More information about the webkit-reviews mailing list