[webkit-reviews] review requested: [Bug 93961] Automatic features should work in sandboxed iframes if "allow-scripts" flag is set : [Attachment 161974] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Sep 4 00:01:29 PDT 2012


Christophe Dumez <christophe.dumez at intel.com> has asked  for review:
Bug 93961: Automatic features should work in sandboxed iframes if
"allow-scripts" flag is set
https://bugs.webkit.org/show_bug.cgi?id=93961

Attachment 161974: Patch
https://bugs.webkit.org/attachment.cgi?id=161974&action=review

------- Additional Comments from Christophe Dumez <christophe.dumez at intel.com>
Unfortunately, the present patch removes the test cases that check that
autoplay / autofocus are blocked in sandboxed iframes. Those tests are no
longer working since they rely on the "allow-scripts" flag to be set in order
to work.
It is not easy to automatically test this but I'm open to suggestions on how to
better handle this.

I have validated the patch using the LayoutTests added in the patch and the
following manual tests:
http://samples.msdn.microsoft.com/ietestcenter/html5/sandbox/automatic-feature-
block-autoplay-video.htm
http://samples.msdn.microsoft.com/ietestcenter/html5/sandbox/automatic-feature-
block-autofocus-form-control.htm


More information about the webkit-reviews mailing list