[webkit-reviews] review granted: [Bug 95204] Allow child-frame content in hit-tests. : [Attachment 161932] Patch

[bugzilla-daemon at webkit.org]

Antonio Gomes <tonikitoo at webkit.org> has granted Allan Sandfeld Jensen
<allan.jensen at nokia.com>'s request for review:
Bug 95204: Allow child-frame content in hit-tests.
https://bugs.webkit.org/show_bug.cgi?id=95204

Attachment 161932: Patch
https://bugs.webkit.org/attachment.cgi?id=161932&action=review

------- Additional Comments from Antonio Gomes <tonikitoo at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=161932&action=review


r=me

> Source/WebCore/dom/Document.cpp:1387
> +PassRefPtr<NodeList> Document::nodesFromRect(int centerX, int centerY,
unsigned topPadding, unsigned rightPadding, unsigned bottomPadding, unsigned
leftPadding, bool ignoreClipping, bool allowShadowContent, bool
allowChildFrameContent) const

it is getting time for us to improve this API. This bunch of books are getting
out of control. We could even pass a HitTestRequest to it?

> Source/WebCore/rendering/RenderLayer.cpp:3452
> +    if (Frame *frame = renderer() ? renderer()->frame() : 0)
> +	   return (frame == frame->page()->mainFrame());
> +    return false;

lets do

if (!renderer())
return false;

return blah == bleh ? a : b;

> Source/WebCore/rendering/RenderLayer.h:376
> +    bool isRootLayerOfMainFrame() const;

should be private?