[webkit-reviews] review granted: [Bug 95565] MediaStream API: Add Ice-related functionality to RTCPeerConnection : [Attachment 161894] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Tommy Widenflycht
<tommyw at google.com>'s request for review:
Bug 95565: MediaStream API: Add Ice-related functionality to RTCPeerConnection
https://bugs.webkit.org/show_bug.cgi?id=95565

Attachment 161894: Patch
https://bugs.webkit.org/attachment.cgi?id=161894&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=161894&action=review


> Source/WebCore/Modules/mediastream/RTCPeerConnection.cpp:186
> -    return "";
> +    return ASCIILiteral("");

You don't actually need this here.  The benefit of ASCIILiteral is that it
avoid a strlen, a malloc, and a memcpy, none of which happen for the empty
string.  :)