[webkit-reviews] review granted: [Bug 100879] ScrollingStateNode::cloneAndResetNode() should not be virtual : [Attachment 171706] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Beth Dakin
<bdakin at apple.com>'s request for review:
Bug 100879: ScrollingStateNode::cloneAndResetNode() should not be virtual
https://bugs.webkit.org/show_bug.cgi?id=100879

Attachment 171706: Patch
https://bugs.webkit.org/attachment.cgi?id=171706&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=171706&action=review


> Source/WebCore/page/scrolling/ScrollingStateNode.h:55
> +    PassOwnPtr<ScrollingStateNode> cloneAndResetNode();

Maybe we should also change the name; the trailing 'node' is redundant, and
suggests that it should take a node parameter.

> Source/WebCore/page/scrolling/ScrollingStateScrollingNode.h:44
> +    ScrollingStateScrollingNode(ScrollingStateScrollingNode*);

Is this a copy constructor? Those normally take const Foo&