[webkit-reviews] review granted: [Bug 100538] malformed X-XSS-Protection headers not reported : [Attachment 171300] Patch, fix style, add missing file.

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Thomas Sepez <tsepez at chromium.org>'s
request for review:
Bug 100538: malformed X-XSS-Protection headers not reported
https://bugs.webkit.org/show_bug.cgi?id=100538

Attachment 171300: Patch, fix style, add missing file.
https://bugs.webkit.org/attachment.cgi?id=171300&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=171300&action=review


> Source/WebCore/html/parser/XSSAuditor.cpp:225
> +	       DEFINE_STATIC_LOCAL(String, consoleMessageStart,
(ASCIILiteral("Error parsing header X-XSS-Protection: ")));
> +	       DEFINE_STATIC_LOCAL(String, consoleMessageSeparator,
(ASCIILiteral(": ")));
> +	       DEFINE_STATIC_LOCAL(String, consoleMessageEnd, (ASCIILiteral(".
The default protections will be applied.")));

There isn't really a benefit to defining these statics since you're going to
concatenate them anyway.  The most efficient thing is to just write out the
whole concatenation on one line with the literals and everything.