[webkit-reviews] review canceled: [Bug 99207] truncated-direct-png-image.html should not be a reftest : [Attachment 169494] Patch

Wed Oct 31 09:41:46 PDT 2012

Julien Chaffraix <jchaffraix at webkit.org> has canceled Nick Carter
<nick at chromium.org>'s request for review:
Bug 99207: truncated-direct-png-image.html should not be a reftest
https://bugs.webkit.org/show_bug.cgi?id=99207

Attachment 169494: Patch
https://bugs.webkit.org/attachment.cgi?id=169494&action=review

------- Additional Comments from Julien Chaffraix <jchaffraix at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=169494&action=review

Nick, none of the patches you posted run on the EWS as the Mac's
TestExpectations didn't apply properly. Could you post a patch against WebKit
trunk that would apply cleanly? This would give the CC'ed reviewers more
confidence in your change. I cannot comment on the change as I don't know
window.internals.layerTreeAsText output enough.

> LayoutTests/compositing/images/truncated-direct-png-image.html:1
>  <html>

Usually we put a DOCTYPE to test to avoid having them run in quirks mode
(something most people don't want).