[webkit-reviews] review granted: [Bug 100247] [Qt][WK2] Fix "Unable to find a renderable master window QQuickView" warnings in tst_QQuickWebView : [Attachment 171673] Patch

[bugzilla-daemon at webkit.org]

Jocelyn Turcotte <jocelyn.turcotte at digia.com> has granted Balazs Kelemen
<kbalazs at webkit.org>'s request for review:
Bug 100247: [Qt][WK2] Fix "Unable to find a renderable master window
QQuickView" warnings in tst_QQuickWebView
https://bugs.webkit.org/show_bug.cgi?id=100247

Attachment 171673: Patch
https://bugs.webkit.org/attachment.cgi?id=171673&action=review

------- Additional Comments from Jocelyn Turcotte <jocelyn.turcotte at digia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=171673&action=review


> Source/WebKit2/UIProcess/API/qt/tests/qquickwebview/tst_qquickwebview.cpp:331

>      showWebView();

Yeah showWebView is a test on its own and I think it's wrong that tests are
using it to show the web view, but this cached a couple of bugs so no reason to
remove it :)

>
Source/WebKit2/UIProcess/API/qt/tests/qquickwebview/tst_qquickwebview.cpp:-344
> -    // We have to explicitly move the window into the screen, otherwise it's
not rendered.
> -    m_window->setGeometry(0, 0, 300, 400);
> -    m_window->show();

Humm, not sure why this was needed.