[webkit-reviews] review granted: [Bug 98800] RoboHornetPro spends ~25% of total test time in WebCore::Region::Shape methods : [Attachment 171585] A much simpler approach. Kudos to smfr for being a smart man.

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has granted Eric Seidel <eric at webkit.org>'s request
for review:
Bug 98800: RoboHornetPro spends ~25% of total test time in
WebCore::Region::Shape methods
https://bugs.webkit.org/show_bug.cgi?id=98800

Attachment 171585: A much simpler approach. Kudos to smfr for being a smart
man.
https://bugs.webkit.org/attachment.cgi?id=171585&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=171585&action=review


> Source/WebCore/ChangeLog:35
> +	   * rendering/RenderLayerCompositor.cpp:
> +	   (LazyRegion):
> +	   (WebCore::LazyRegion::unite):
> +	   (WebCore::LazyRegion::updateRegionIfNecessary):
> +	   (WebCore::LazyRegion::region):
> +	   (WebCore):
> +	   (WebCore::RenderLayerCompositor::OverlapMap::overlapsLayers):
> +	  
(WebCore::RenderLayerCompositor::OverlapMap::pushCompositingContainer):
> +	   (RenderLayerCompositor::OverlapMap):

I don't think you regenerated your changelog.  There ain't no LazyRegion no mo.


> Source/WebCore/rendering/RenderLayerCompositor.cpp:112
> +	   const RectList& layerRects = m_overlapStack.last();
> +	   for (unsigned i = 0; i < layerRects.size(); i++)
> +	       if (layerRects[i].intersects(bounds))
> +		   return true;

Please add braces around the for loop.